[ZEPPELIN-1417] Bugfix of "Connect to existing process" #1411
Conversation
astroshim
changed the title
|
Looks good to me, thank you @astroshim I'm a bit confused - in JIRA fix-for version is only 0.6.2 but PR is to master branch (which implies 0.7.0 as well) Could you please clarify, which releases shall this be part of? |
|
@bzz Thank you for review and sorry for making you confused. |
|
Merging to master if there is no further discussion |
| for (InterpreterInfo info : interpreterInfos) { | ||
| if (option.isRemote()) { | ||
| if (option.isConnectExistingProcess()) { | ||
| if (option.isExistingProcess()) { |
There was a problem hiding this comment.
I think InterpreterOption.isConnectExistingProcess() is no longer used in anywhere in the code base.
To avoid confusion between InterpreterOption.isConnectExistingProcess() and InterpreterOption. isExistingProcess(), @astroshim could you remove InterpreterOption.isConnectExistingProcess() method?
There was a problem hiding this comment.
@Leemoonsoo You're right. I just removed. Thanks.
|
LGTM and merge if there're no more discussions |
### What is this PR for? This PR fixes [ZEPPELIN-1417](https://issues.apache.org/jira/browse/ZEPPELIN-1417 ). ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1417 ### How should this be tested? 1. click `edit` whatever interpreter you want on interpreter setting page. 2. check the `Connect to existing process` and set `host` or `port` value. 3. uncheck the `Connect to existing process` and save 4. run paragraph with just you saved interpreter. ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: astroshim <[email protected]> Closes apache#1411 from astroshim/ZEPPELIN-1417 and squashes the following commits: 0ff0f4e [astroshim] remove isConnectExistingProcess() c84046c [astroshim] change to create local interpreter when option is false.
3 participants
What is this PR for?
This PR fixes ZEPPELIN-1417.
What type of PR is it?
Bug Fix
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1417
How should this be tested?
editwhatever interpreter you want on interpreter setting page.Connect to existing processand sethostorportvalue.Connect to existing processand saveQuestions: